Patches to improve compatibility with modern C++ standard

[Yu Jin]

Am Mo., 4. Mai 2020 um 16:04 Uhr schrieb Kornel Benko <kornel at lyx.org>:

> Am Mon, 4 May 2020 15:33:02 +0200
> schrieb Thibaut Cuvelier <dourouc05 at gmail.com>:
>
> > Yes, your patch works (MSVC 19, again, that's all I have on my computer).
> >
> > By the way, in my original email, there are modifications to Boost, but
> it
> > would be better to update it to a more recent version. The needed patch
> was
> > integrated nine months ago.
> >
> > Thibaut Cuvelier
> >
> >
> > On Mon, 4 May 2020 at 14:30, Kornel Benko <kornel at lyx.org> wrote:
> >
> > > Am Mon, 4 May 2020 12:53:42 +0200
> > > schrieb Thibaut Cuvelier <dourouc05 at gmail.com>:
> > >
> > > > You can use the equivalent parameter /std:
> > > >
> > >
> https://docs.microsoft.com/en-us/cpp/build/reference/std-specify-language-standard-version?view=vs-2019
> > > >
> > > > Example: cl /std:c++14. If the standard is not supported, you get the
> > > warning D9002.
> > > >
> > > > Thibaut Cuvelier
> > > >
> > >
> > > The attached patch is against master tree.
> > > Could you please test if it works with old and with new msvc compiler?
> > >
> > > (I cannot test, lacking windows OS)
> > >         Kornel
> > > --
> > > lyx-devel mailing list
> > > lyx-devel at lists.lyx.org
> > > http://lists.lyx.org/mailman/listinfo/lyx-devel
> > >
>
>
> Eugene, could you please test the patch?
>
Hmm, patch does not work for me, I get these errors:

Fehler C2143 Syntaxfehler: Es fehlt "," vor "<" LyX (applications\LyX\LyX)
C:\lyx\master\src\BranchList.cpp 30
Fehler MSB3073 Der Befehl "setlocal
"C:\Program Files\CMake\bin\cmake.exe" -DBUILD_TYPE=Debug -P
cmake_install.cmake
if %errorlevel% neq 0 goto :cmEnd
:cmEnd
endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone
:cmErrorLevel
exit /b %1
:cmDone
if %errorlevel% neq 0 goto :VCEnd
:VCEnd" wurde mit dem Code 1 beendet. INSTALL C:\Program Files
(x86)\Microsoft Visual
Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets
149
Fehler C2039 "unary_function" ist kein Member von "std". LyX
(applications\LyX\LyX) C:\lyx\master\src\BranchList.cpp 30
Fehler C2504 "unary_function": Basisklasse undefiniert LyX
(applications\LyX\LyX) C:\lyx\master\src\BranchList.cpp 30
Fehler C7568 Nach der angenommenen Funktionsvorlage "unary_function" fehlt
die Argumentliste. LyX (applications\LyX\LyX) C:\lyx\master\src\Format.cpp
58
Fehler C3770 "unknown-type": ist keine gültige Basisklasse LyX
(applications\LyX\LyX) C:\lyx\master\src\Format.cpp 58
Fehler C7568 Nach der angenommenen Funktionsvorlage "unary_function" fehlt
die Argumentliste. LyX (applications\LyX\LyX) C:\lyx\master\src\Format.cpp
72
Fehler C3770 "unknown-type": ist keine gültige Basisklasse LyX
(applications\LyX\LyX) C:\lyx\master\src\Format.cpp 72
Fehler C7568 Nach der angenommenen Funktionsvorlage "unary_function" fehlt
die Argumentliste. LyX (applications\LyX\LyX) C:\lyx\master\src\Format.cpp
86
Fehler C3770 "unknown-type": ist keine gültige Basisklasse LyX
(applications\LyX\LyX) C:\lyx\master\src\Format.cpp 86
Fehler C2039 "unary_function" ist kein Member von "std". LyX
(applications\LyX\LyX) C:\lyx\master\src\IndicesList.cpp 30
Fehler C2504 "unary_function": Basisklasse undefiniert LyX
(applications\LyX\LyX) C:\lyx\master\src\IndicesList.cpp 30
Fehler C2143 Syntaxfehler: Es fehlt "," vor "<" LyX (applications\LyX\LyX)
C:\lyx\master\src\IndicesList.cpp 30
Fehler C2039 "unary_function" ist kein Member von "std". LyX
(applications\LyX\LyX) C:\lyx\master\src\IndicesList.cpp 46
Fehler C2504 "unary_function": Basisklasse undefiniert LyX
(applications\LyX\LyX) C:\lyx\master\src\IndicesList.cpp 46
Fehler C2143 Syntaxfehler: Es fehlt "," vor "<" LyX (applications\LyX\LyX)
C:\lyx\master\src\IndicesList.cpp 46

They all seem to be related to unary_function, which makes sense. The error
with the exit code 1 though, I have seen it a few times but did not see any
functionality limitations, so its probably caused by something else.

Eugene
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200505/8b5dd23f/attachment.html>