[LyX/master] Revert last three commits.

[Richard Kimberly Heck]

On 5/1/20 5:52 AM, Jean-Marc Lasgouttes wrote:
> Le 26/04/2020 à 08:49, Richard Kimberly Heck a écrit :
>> commit 7b9dc7bc9e26b26d15ca4c3e5b2d0383ea97733f
>> Author: Richard Kimberly Heck <rikiheck at lyx.org>
>> Date:   Sun Apr 26 03:08:35 2020 -0400
>>
>>      Revert last three commits.
>>           There are other issues here. The big one is in
>> TextMetrics::getPitNearY,
>>      where -1 is used as a 'special' return value for pit.
>
> This special value of -1 is nothing else than the "npos" that we get
> in STL for things like strings. We could define a value lyx::npos
> which is this special value for pit_type and pos_type and get rid of
> the signedness.

Worth a shot, I suppose. We could define it as UNIT_MAX - 1 or something.


> What were the other issues?

I can't recall, other than that boatloads of warnings suddenly appeared.
I'll have a look.

Riki