New DocBook support (0002)

[Thibaut Cuvelier]

On Sat, 27 Jun 2020 at 00:18, Pavel Sanda <sanda at lyx.org> wrote:

> On Fri, Jun 26, 2020 at 11:42:23PM +0200, Thibaut Cuvelier wrote:
> > > * 0001 is trivial, now in. I haven't seen any makefile entries, so
> these
> > > autotests won't be distributed with tarballs. I do not know whether
> this is
> > > what you want.
> > >
> >
> > I didn't know that anything was required to get them in tarballs??? As
> for
> > the other tests, I guess it would not make sense not to include them.
>
> Tarball is not archive of everything in master, any file which is to be
> included in it must be picked by makefile. Not having these autotest is
> just
> fine, when only devs are supposed to run those. If on the other hand there
> is
> some dependency on other tools which might change the output on different
> systems it might be worth to include it.
>

Only devs would need these tests.

> > * 0002 - you remove checkDocBook() call, yet the code of the function
> > > remains. Is it still needed?
> >
> > Basically, this function should be replaced by True, so it can be safely
> > removed.
>
> Ok, the patch please :)
>

Here it is :). (Updated patch #2, not cumulative.)

Pavel
> --
> lyx-devel mailing list
> lyx-devel at lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200627/257109a4/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Configure-script-update-names-for-new-DocBook-suppor.patch
Type: application/octet-stream
Size: 7539 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200627/257109a4/attachment-0001.obj>