New DocBook support (0002)

Pavel Sanda sanda at lyx.org
Fri Jun 26 22:17:46 UTC 2020


On Fri, Jun 26, 2020 at 11:42:23PM +0200, Thibaut Cuvelier wrote:
> I'll keep these in mind. (I'm not really used to mailing lists???) Is this
> answer better in these regards?

Yes, thanks.

> > * 0001 is trivial, now in. I haven't seen any makefile entries, so these
> > autotests won't be distributed with tarballs. I do not know whether this is
> > what you want.
> >
> 
> I didn't know that anything was required to get them in tarballs??? As for
> the other tests, I guess it would not make sense not to include them.

Tarball is not archive of everything in master, any file which is to be
included in it must be picked by makefile. Not having these autotest is just
fine, when only devs are supposed to run those. If on the other hand there is
some dependency on other tools which might change the output on different
systems it might be worth to include it.

> > * 0002 - you remove checkDocBook() call, yet the code of the function
> > remains. Is it still needed?
> 
> Basically, this function should be replaced by True, so it can be safely
> removed.

Ok, the patch please :)

Pavel


More information about the lyx-devel mailing list