[LyX/2.3.x] Use data from src/lyxwinres.rc to generate lyx.coff for the Windows build.

[Enrico Forestieri]

On Wed, Jun 17, 2020 at 05:03:21PM +0200, Enrico Forestieri wrote:
> On Wed, Jun 17, 2020 at 04:06:39PM +0200, Yu Jin wrote:
> > Am Mi., 17. Juni 2020 um 15:48 Uhr schrieb Enrico Forestieri <forenr at lyx.org
> > >:
> > 
> > > On Wed, Jun 17, 2020 at 03:38:00PM +0200, Kornel Benko wrote:
> > > >
> > > > Maybe following has to be specified too (inside the if(WIN32))
> > > >       ENABLE_LANGUAGE(RC)
> > >
> > > Note that you have to make sure the icons are available. This is done
> > > in src/Makefile.am by copying them as follows:
> > >
> > > if LYX_WIN_RESOURCE
> > > .rc.o:
> > >         cp $(top_srcdir)/development/Win32/packaging/icons/lyx_*32x32.ico .
> > >         $(RC) -I$(top_builddir) --preprocessor "$(CPP) -xc-header
> > > -DRC_INVOKED" $< -o $@
> > > endif
> > >
> > 
> > Actually I just noticed that the icon in the picture you sent earlier is
> > different from the icon I am used to. lyx_32x32.ico and lyx_doc_32x32.ico
> > are different from lyx.ico, which is used on Windows. What is the guideline
> > here?
> 
> Those are the icons that have always been used when building with
> autotools. They correspond to lyx.svg and lyx_doc.svg. It seems that
> the cmake builds instead use lyx.ico. I don't think there was a policy
> about icons. I think that someone simply liked more lyx.ico and used it
> as an icon when building with cmake. Note that lyxwinres.rc provides an
> icon for both the executable and the documents.

In master I changed the autotools build to use the same icon as in the
cmake case.

-- 
Enrico