Tweaking lib/symbols for XML entities

[Kornel Benko]

Am Mon, 15 Jun 2020 00:57:06 +0200
schrieb Thibaut Cuvelier <dourouc05 at gmail.com>:

> Dear list,
> 
> Here is a new version of the patches with the following changes:
> - Kornel's patches for tests/dummy_functions.cpp and tex2lyx/dummy_impl.cpp
> - rebased on top of 57272e8
> <https://github.com/cburschka/lyx/commit/57272e837b148975817440bdc6a66b9935fa00a3>
> - eliminated warnings in fontToTagDocBook (output_docbook), as signalled by
> Pavel: it now returns a string, like fontToTag in output_xhtml, instead of
> a reference to docstring
> - eliminated warnings in InsetCounter and InsetLabel
> It seems to work for me, when compiling LyX, tex2lyx, and check_layout
> (indeed, as I'm using CMake, only LyX got compiled). I think no other issue
> has been raised on that code (otherwise, just send a reminder :)).
> 
> Thibaut Cuvelier
> 
> 
> On Sun, 14 Jun 2020 at 23:35, Kornel Benko <kornel at lyx.org> wrote:
> 
> > Am Sun, 14 Jun 2020 23:07:50 +0200
> > schrieb Pavel Sanda <sanda at lyx.org>:
> >
> > > On Sun, Jun 14, 2020 at 10:12:31PM +0200, Kornel Benko wrote:
> > > > > Can you try to import my patch into dummy_functions.cpp ?
> > > > > Pavel
> > > >
> > > > Works, if inserted also
> > > >     #include "xml.h"
> > > > into src/tests/dummy_functions.cpp.
> > >
> > > Cool, can you post the patch for convenience? P
> >
> > Attached.
> >
> >         Kornel
> > --
> > lyx-devel mailing list
> > lyx-devel at lists.lyx.org
> > http://lists.lyx.org/mailman/listinfo/lyx-devel
> >

Compiles fine, with some warnings.
...
/usr2/src/lyx/lyx-test/src/output_docbook.cpp:44:19: warning: ‘const string
lyx::{anonymous}::fontToDocBookTag(lyx::xml::FontTypes)’ defined but not used [-Wunused-function]
 std::string const fontToDocBookTag(xml::FontTypes type) {
                   ^~~~~~~~~~~~~~~~
...
/usr2/src/lyx/lyx-test/src/output_xhtml.cpp:52:34: warning: returning reference to
temporary [-Wreturn-local-addr] return from_utf8("em");
                                  ^
/usr2/src/lyx/lyx-test/src/output_xhtml.cpp:54:33: warning: returning reference to
temporary [-Wreturn-local-addr] return from_utf8("b");
                                 ^
/usr2/src/lyx/lyx-test/src/output_xhtml.cpp:56:35: warning: returning reference to
temporary [-Wreturn-local-addr] return from_utf8("dfn");
                                   ^
/usr2/src/lyx/lyx-test/src/output_xhtml.cpp:60:33: warning: returning reference to
temporary [-Wreturn-local-addr] return from_utf8("u");
                                 ^
/usr2/src/lyx/lyx-test/src/output_xhtml.cpp:63:35: warning: returning reference to
temporary [-Wreturn-local-addr] return from_utf8("del");
                                   ^
/usr2/src/lyx/lyx-test/src/output_xhtml.cpp:65:33: warning: returning reference to
temporary [-Wreturn-local-addr] return from_utf8("i");
                                 ^
/usr2/src/lyx/lyx-test/src/output_xhtml.cpp:84:36: warning: returning reference to
temporary [-Wreturn-local-addr] return from_utf8("span");
                                    ^
/usr2/src/lyx/lyx-test/src/output_xhtml.cpp:87:22: warning: returning reference to
temporary [-Wreturn-local-addr] return docstring();
...

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200615/2fcfcbcd/attachment.asc>