Fwd: New Defects reported by Coverity Scan for LyX

[Richard Kimberly Heck]

On 7/8/20 11:28 AM, Jean-Marc Lasgouttes wrote:
> Le 08/07/2020 à 14:53, Jean-Marc Lasgouttes a écrit :
>> Hello,
>>
>> More work for Thibaut :) I ran coverity against master and here is
>> what it returns (below).
>
> Now I tried clang 10 and I get the following 2 warnings. Besides the
> overloading problem, the indentation issue seems to be related with
> the fact that you use spaces as indentation, whereas we use tabs.
>
> I am not sure what is the best way to fix indentation now that the
> patches are in. Ideas?

Most of it is fine, actually. There are isolated instances of spaces.
I'll see if I can find them.

Riki


>
> In file included from ../../master/src/factory.cpp:29:
> ../../master/src/insets/InsetCounter.h:42:7: warning:
> 'lyx::InsetCounter::docbook' hides overloaded virtual function
> [-Woverloaded-virtual]
>         void docbook(odocstream &, OutputParams const &) const;
>              ^
> ../../master/src/insets/InsetCommand.h:92:7: note: hidden overloaded
> virtual function 'lyx::InsetCommand::docbook' declared here: type
> mismatch at 1st parameter ('lyx::XMLStream &' vs 'lyx::odocstream &'
> (aka 'basic_ostream<wchar_t, char_traits<wchar_t> > &'))
>         void docbook(XMLStream &, OutputParams const &) const;
>              ^
> 1 warning generated.
> ../../master/src/output_docbook.cpp:363:10: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>                 if (!special_case && firstInset->lyxCode() ==
> lyx::LISTINGS_CODE)
>                 ^
> ../../master/src/output_docbook.cpp:359:13: note: previous statement
> is here
>             if (!special_case && firstInset->lyxCode() == lyx::ERT_CODE)
>             ^
> 1 warning generated.