New DocBook support (0004)

[Thibaut Cuvelier]

On Fri, 3 Jul 2020 at 19:27, Pavel Sanda <sanda at lyx.org> wrote:

> On Fri, Jul 03, 2020 at 04:07:20PM +0200, Thibaut Cuvelier wrote:
> > On Thu, 2 Jul 2020 at 16:24, Pavel Sanda <sanda at lyx.org> wrote:
> > > 1) OutputParams::DOCBOOK5 is used, but not defined.
> >
> > Well, then it's there one commit in advance :)! Similarly, there's
> already
> > a fontToDocBookTag function that is only used by commit #5.
>
> Sure, I figured that out; the difference is that redudant fontToDocBookTag
> throws
> innocent warning, while missing OutputParams::DOCBOOK5 breaks compilation
> for everyone which which is no-go. So we either should better parcel
> 0004 vs 0005 or merge them.
>

Actually, I misread your message, I thought it was defined but not used...
Here is an updated version of the two patches.


> > 2) lyx_2_4.py:
> > >    You remove \outputformat docbook from header, but why?
> > >    If someone had this as default output wouldn't he intend to use
> docbook5
> > >    as default now?
> > >
> >
> > Is there any notion of "default output" in LyX?
> >
> > Before, this parameter was used to enable DocBook support. This support
> is
>
> Could be wrong but my reading was that's not enabling docbook, but setting
> docbook
> as default output format.


I tried the existing code. Creating a new DocBook document from the
template does not set \outputformat, so it's not required to generate a
DocBook file. Nothing is set as "Default output format" either (and the
dropdown list only shows Default and LyXHTML — this version of LyX doesn't
seem to find my LaTeX installation…).

Shall I remove this part of the patch? (It doesn't look used a lot: the
only occurrence I could find is `guiErrorType` in GuiErrorList.cpp. The
other values for outputformat are used much more often.)
How would you make DocBook appear in the dropdown list for the default
output format? Or is it only because `GuiDocument::updateDefaultFormat`
calls `BufferParams::exportableFormats` with `only_viewable` set to true?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200704/ff2fcaa8/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-required-elements-in-the-layouts-to-support-DocB.patch
Type: application/x-patch
Size: 12582 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200704/ff2fcaa8/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-New-DocBook-support.patch
Type: application/x-patch
Size: 222180 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200704/ff2fcaa8/attachment-0003.bin>