[LyX/master] Cmake build: Remove use of -Wno-shadow.
Kornel Benko
kornel at lyx.org
Fri Feb 20 15:36:51 UTC 2026
commit bd6d5c86fe62dda596d6c11952044a9a03caa086
Author: Kornel Benko <kornel at lyx.org>
Date: Fri Feb 20 16:34:34 2026 +0100
Cmake build: Remove use of -Wno-shadow.
This is not needed anymore after cleanup from Jürgen and Jean-Marc
---
src/CMakeLists.txt | 10 ----------
src/frontends/CMakeLists.txt | 1 -
src/frontends/qt/CMakeLists.txt | 12 ------------
src/graphics/CMakeLists.txt | 3 ---
src/insets/CMakeLists.txt | 12 ------------
src/mathed/CMakeLists.txt | 17 -----------------
src/support/CMakeLists.txt | 3 ---
src/tests/CMakeLists.txt | 4 ----
src/tex2lyx/CMakeLists.txt | 6 ------
9 files changed, 68 deletions(-)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index d6974fa2b8..b403c8e4d0 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -45,16 +45,6 @@ handle_source_option("CXX" "${TOP_SRC_DIR}/src/LyX.cpp" -Wno-error -Wno-invalid-
handle_source_option("CXX" ${TOP_SRC_DIR}/src/TextMetrics.cpp -Wno-implicit-int-float-conversion)
handle_source_option("CXX" ${TOP_SRC_DIR}/src/CursorSlice.cpp -Wno-null-dereference)
-foreach(_base AspellChecker BiblioInfo Buffer BufferEncodings BufferList BufferParams BufferView
- Changes Compare Converter Counters Cursor CursorSlice CutAndPaste
- DocIterator EnchantChecker Font FontInfo FontList Format HunspellChecker InsetIterator
- InsetList Language LaTeX LaTeXFeatures Layout LayoutFile LayoutModuleList LyX LyXRC
- MetricsInfo PDFOptions ParIterator Paragraph ParagraphMetrics ParagraphParameters
- Row RowPainter SpecialChar Statistics TexRow Text TextClass TextMetrics Thesaurus TocBackend TocBuilder Trans
- Undo VSpace factory lyxfind output_docbook output_latex output_plaintext output_xhtml
- xml)
- handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp -Wno-shadow)
-endforeach()
if (${LYX_DEBUG_SANITIZE} MATCHES "ADDRESS")
foreach(_base BiblioInfo Encoding LaTeX LaTeXFeatures LayoutFile Text VCBackend lyxfind Preamble)
handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp -Wno-maybe-uninitialized)
diff --git a/src/frontends/CMakeLists.txt b/src/frontends/CMakeLists.txt
index 59ee022156..bc33d94425 100644
--- a/src/frontends/CMakeLists.txt
+++ b/src/frontends/CMakeLists.txt
@@ -13,7 +13,6 @@ add_subdirectory(qt)
file(GLOB frontends_sources ${TOP_SRC_DIR}/src/frontends/${LYX_CPP_FILES})
file(GLOB frontends_headers ${TOP_SRC_DIR}/src/frontends/${LYX_HPP_FILES})
-handle_source_option("CXX" ${TOP_SRC_DIR}/src/frontends/WorkAreaManager.cpp -Wno-shadow)
if(NOT LYX_MERGE_FILES)
add_library(frontends ${library_type} ${frontends_sources} ${frontends_headers})
else()
diff --git a/src/frontends/qt/CMakeLists.txt b/src/frontends/qt/CMakeLists.txt
index 0b2dd5b823..05d4c4abf4 100644
--- a/src/frontends/qt/CMakeLists.txt
+++ b/src/frontends/qt/CMakeLists.txt
@@ -15,18 +15,6 @@ if (${LYX_DEBUG_SANITIZE} MATCHES "ADDRESS")
handle_source_option("CXX" ${TOP_SRC_DIR}/src/frontends/qt/${_base}.cpp -Wno-maybe-uninitialized)
endforeach()
endif()
-foreach(_base Dialog DialogFactory FindAndReplace FloatPlacement
- GuiApplication GuiBibitem GuiBibtex GuiBox GuiBranch GuiBranches
- GuiChanges GuiCharacter GuiCitation GuiClipboard GuiCommandBuffer GuiCompleter GuiCounter
- GuiDelimiter GuiDocument GuiERT GuiExternal
- GuiFontLoader GuiGraphics GuiHSpace GuiHyperlink GuiInclude GuiIndex GuiIndices GuiInfo GuiInputMethod
- GuiLabel GuiLine GuiListings GuiLog GuiLyXFiles GuiNote GuiPainter GuiParagraph GuiPhantom GuiPrefs GuiPrintNomencl GuiPrintindex
- GuiRef GuiSelectionManager GuiSendto GuiSpellchecker GuiSymbols
- GuiTabular GuiTabularCreate GuiThesaurus GuiToolbar
- GuiView GuiVSpace GuiViewSource GuiWorkArea GuiWrap
- InsetParamsDialog InsetParamsWidget LayoutBox Menus TocModel TocWidget Toolbars)
- handle_source_option("CXX" ${TOP_SRC_DIR}/src/frontends/qt/${_base}.cpp -Wno-shadow)
-endforeach()
handle_source_option("CXX" ${TOP_SRC_DIR}/src/frontends/qt/GuiDocument.cpp -Wno-null-dereference)
handle_source_option("CXX" ${TOP_SRC_DIR}/src/frontends/qt/GuiWorkArea.cpp -Wno-unreachable-code-return)
foreach(_base DialogFactory GuiApplication GuiCitation GuiImage GuiListings GuiNote GuiPhantom GuiView GuiWrap Menus)
diff --git a/src/graphics/CMakeLists.txt b/src/graphics/CMakeLists.txt
index 682b2f54a3..0d0ab20406 100644
--- a/src/graphics/CMakeLists.txt
+++ b/src/graphics/CMakeLists.txt
@@ -12,9 +12,6 @@ file(GLOB graphics_headers ${TOP_SRC_DIR}/src/graphics/${LYX_HPP_FILES})
if (${LYX_DEBUG_SANITIZE} MATCHES "ADDRESS")
handle_source_option("CXX" ${TOP_SRC_DIR}/src/graphics/epstools.cpp -Wno-maybe-uninitialized)
endif()
-foreach(_base GraphicsLoader PreviewImage PreviewLoader)
- handle_source_option("CXX" ${TOP_SRC_DIR}/src/graphics/${_base}.cpp -Wno-shadow)
-endforeach()
foreach(_base GraphicsConverter PreviewLoader)
#handle_source_option("CXX" ${TOP_SRC_DIR}/src/graphics/${_base}.cpp -Wno-deprecated-copy-with-user-provided-dtor)
endforeach()
diff --git a/src/insets/CMakeLists.txt b/src/insets/CMakeLists.txt
index 3c24d90ea8..18e5eab618 100644
--- a/src/insets/CMakeLists.txt
+++ b/src/insets/CMakeLists.txt
@@ -18,18 +18,6 @@ if (${LYX_DEBUG_SANITIZE} MATCHES "ADDRESS")
handle_source_option("CXX" ${TOP_SRC_DIR}/src/insets/${_base}.cpp -Wno-null-dereference)
endforeach()
endif()
-foreach(_base InsetExternal ExternalSupport Inset InsetArgument
- InsetBibitem InsetBibtex InsetBox InsetBranch
- InsetCaption InsetCaptionable InsetCitation InsetCollapsible InsetCommand InsetCommandParams InsetCounter
- InsetDynamicArgs InsetERT InsetFlex InsetFloat InsetFloatList InsetFoot InsetFootlike
- InsetGraphics InsetHyperlink InsetInfo InsetIPA InsetIPAMacro InsetInclude InsetIndex InsetIndexMacro
- InsetLabel InsetLayout InsetLine InsetListings InsetListingsParams InsetMarginal
- InsetNewline InsetNomencl InsetNote
- InsetPhantom InsetPreview InsetQuotes InsetRef InsetScript InsetSeparator InsetSpace InsetSpecialChar
- InsetTOC InsetTabular InsetText InsetTextbreak InsetVSpace InsetWrap
- RenderButton RenderGraphic RenderPreview)
- handle_source_option("CXX" ${TOP_SRC_DIR}/src/insets/${_base}.cpp -Wno-shadow)
-endforeach()
foreach(_base InsetArgument InsetBibitem InsetBox InsetBranch InsetCaption InsetCitation
InsetCommand InsetCommandParams InsetFloat InsetFoot InsetIPA InsetIPAMacro InsetInclude InsetIndex
InsetIndexMacro InsetLabel InsetListings InsetNomencl InsetNote InsetPhantom InsetScript
diff --git a/src/mathed/CMakeLists.txt b/src/mathed/CMakeLists.txt
index e477eb1683..a0692b6d65 100644
--- a/src/mathed/CMakeLists.txt
+++ b/src/mathed/CMakeLists.txt
@@ -11,23 +11,6 @@ file(GLOB mathed_headers ${TOP_SRC_DIR}/src/mathed/${LYX_HPP_FILES})
lyx_add_msvc_pch(mathed)
handle_source_option("CXX" ${TOP_SRC_DIR}/src/mathed/InsetMathBig.cpp -Wno-implicit-int-float-conversion)
-foreach(_base InsetMath InsetMathAMSArray InsetMathArray
- InsetMathBig InsetMathBoldSymbol InsetMathBox InsetMathBrace
- InsetMathCancel InsetMathCancelto InsetMathCases InsetMathChar InsetMathClass InsetMathColor InsetMathCommand InsetMathComment
- InsetMathDecoration InsetMathDelim InsetMathDiagram InsetMathDiff InsetMathDots
- InsetMathEnsureMath InsetMathEnv InsetMathExFunc InsetMathExInt
- InsetMathFont InsetMathFontOld InsetMathFrac
- InsetMathGrid InsetMathHull InsetMathIntertext InsetMathKern InsetMathLefteqn InsetMathLim
- InsetMathMacro InsetMathMacroArgument InsetMathMacroTemplate InsetMathMatrix
- InsetMathNest InsetMathNumber InsetMathOverset InsetMathPar InsetMathPhantom
- InsetMathRef InsetMathRoot
- InsetMathScript InsetMathSideset InsetMathSize InsetMathSpace InsetMathSpecialChar InsetMathSplit
- InsetMathSqrt InsetMathStackrel InsetMathString InsetMathSubstack InsetMathSymbol
- InsetMathTabular InsetMathTextsize InsetMathUnderset InsetMathUnknown InsetMathXArrow InsetMathXYMatrix
- MacroTable MathAtom MathAutoCorrect MathClass MathData MathExtern
- MathFactory MathParser MathRow MathStream MathSupport)
- handle_source_option("CXX" ${TOP_SRC_DIR}/src/mathed/${_base}.cpp -Wno-shadow)
-endforeach()
foreach(_base InsetMathMacro MathData MathRow)
handle_source_option("CXX" ${TOP_SRC_DIR}/src/mathed/${_base}.cpp -Wno-null-dereference)
endforeach()
diff --git a/src/support/CMakeLists.txt b/src/support/CMakeLists.txt
index b8278c1b95..f4ea2401cd 100644
--- a/src/support/CMakeLists.txt
+++ b/src/support/CMakeLists.txt
@@ -38,9 +38,6 @@ if (${LYX_DEBUG_SANITIZE} MATCHES "ADDRESS")
endforeach()
endif()
handle_source_option("CXX" ${TOP_SRC_DIR}/src/support/environment.cpp -Wno-unreachable-code-return -Wno-null-dereference)
-foreach(_base FileMonitor unicode)
- handle_source_option("CXX" ${TOP_SRC_DIR}/src/support/${_base}.cpp -Wno-shadow)
-endforeach()
handle_source_option("CXX" ${TOP_SRC_DIR}/src/support/checksum.cpp -Wno-null-dereference)
#handle_source_option("CXX" ${TOP_SRC_DIR}/src/support/ForkedCalls.cpp -Wno-delete-non-abstract-non-virtual-dtor)
diff --git a/src/tests/CMakeLists.txt b/src/tests/CMakeLists.txt
index 476e6470e9..5a03903957 100644
--- a/src/tests/CMakeLists.txt
+++ b/src/tests/CMakeLists.txt
@@ -120,10 +120,6 @@ if (${LYX_DEBUG_SANITIZE} MATCHES "ADDRESS")
handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp -Wno-maybe-uninitialized)
endforeach()
endif()
-foreach(_base tests/dummy4checklayout Counters FontInfo Layout LayoutFile
- SpecialChar TextClass insets/InsetLayout tests/check_layout)
- handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp -Wno-shadow)
-endforeach()
foreach(_base TextClass)
#handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp -Wno-deprecated-copy-with-user-provided-dtor)
endforeach()
diff --git a/src/tex2lyx/CMakeLists.txt b/src/tex2lyx/CMakeLists.txt
index 5fee354821..57b33398a6 100644
--- a/src/tex2lyx/CMakeLists.txt
+++ b/src/tex2lyx/CMakeLists.txt
@@ -29,12 +29,6 @@ if (${LYX_DEBUG_SANITIZE} MATCHES "ADDRESS")
handle_source_option("CXX" ${TOP_SRC_DIR}/src/tex2lyx/${_base}.cpp -Wno-maybe-uninitialized)
endforeach()
endif()
-foreach(_base tex2lyx/Context tex2lyx/Parser tex2lyx/Preamble tex2lyx/text
- Counters FontInfo Language Layout LayoutFile LayoutModuleList SpecialChar TextClass
- insets/InsetLayout tex2lyx/dummy_impl tex2lyx/math tex2lyx/table tex2lyx/tex2lyx
- )
- handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp -Wno-shadow)
-endforeach()
foreach(_base TextClass tex2lyx/table tex2lyx/text TextClass)
#handle_source_option("CXX" ${TOP_SRC_DIR}/src/${_base}.cpp -Wno-deprecated-copy-with-user-provided-dtor)
endforeach()
More information about the lyx-cvs
mailing list