[LyX/master] Pass parameters as const reference

Jean-Marc Lasgouttes lasgouttes at lyx.org
Tue Oct 1 09:13:04 UTC 2024


commit 54b68469413754a4d1acb11266e9a80f6276d7f8
Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
Date:   Tue Oct 1 11:12:14 2024 +0200

    Pass parameters as const reference
    
    Spotted by Coverity scan.
---
 src/frontends/qt/GuiApplication.cpp | 4 ++--
 src/frontends/qt/GuiApplication.h   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/frontends/qt/GuiApplication.cpp b/src/frontends/qt/GuiApplication.cpp
index 37623cbc60..082ca57444 100644
--- a/src/frontends/qt/GuiApplication.cpp
+++ b/src/frontends/qt/GuiApplication.cpp
@@ -2326,7 +2326,7 @@ QRectF GuiApplication::baseInputItemRectangle()
 }
 
 
-void GuiApplication::setBaseInputItemRectangle(QRectF rect)
+void GuiApplication::setBaseInputItemRectangle(QRectF const & rect)
 {
 	d->item_rect_base_ = rect;
 }
@@ -2338,7 +2338,7 @@ QTransform GuiApplication::baseInputItemTransform()
 }
 
 
-void GuiApplication::setBaseInputItemTransform(QTransform trans)
+void GuiApplication::setBaseInputItemTransform(QTransform const & trans)
 {
 	d->item_trans_base_ = trans;
 }
diff --git a/src/frontends/qt/GuiApplication.h b/src/frontends/qt/GuiApplication.h
index 239a7e8a02..fa11a72b9e 100644
--- a/src/frontends/qt/GuiApplication.h
+++ b/src/frontends/qt/GuiApplication.h
@@ -192,11 +192,11 @@ public:
 	/// input item rectangle of the base view
 	QRectF baseInputItemRectangle();
 	/// set input item rectangle of the base view
-	void setBaseInputItemRectangle(QRectF rect);
+	void setBaseInputItemRectangle(QRectF const & rect);
 	/// input item transform of the base view
 	QTransform baseInputItemTransform();
 	/// set input item transform of the base view
-	void setBaseInputItemTransform(QTransform trans);
+	void setBaseInputItemTransform(QTransform const & trans);
 
 	/// \name Methods to process FuncRequests
 	//@{


More information about the lyx-cvs mailing list