[LyX/master] Fixup 145af7c2: remove unused method

Jean-Marc Lasgouttes lasgouttes at lyx.org
Wed Jul 10 11:45:47 UTC 2024


commit 8bc3799b354908f22270f9d96b2cce43ebd96d66
Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
Date:   Wed Jul 10 13:42:57 2024 +0200

    Fixup 145af7c2: remove unused method
    
    TextMetrics::firstVisible(), introduced in this commit, is actually unused.
---
 src/TextMetrics.cpp | 11 -----------
 src/TextMetrics.h   |  2 --
 2 files changed, 13 deletions(-)

diff --git a/src/TextMetrics.cpp b/src/TextMetrics.cpp
index a63adf5ebb..6ba15b0251 100644
--- a/src/TextMetrics.cpp
+++ b/src/TextMetrics.cpp
@@ -131,17 +131,6 @@ pair<pit_type, ParagraphMetrics const *> TextMetrics::first() const
 }
 
 
-pair<pit_type, ParagraphMetrics const *> TextMetrics::firstVisible() const
-{
-	// This only works in the main text, I think (bottom > 0)
-	LASSERT(text_->isMainText(), return first());
-	auto it = find_if(par_metrics_.begin(), par_metrics_.end(),
-	                  [] (ParMetricsCache::value_type const & p) {
-	                      return p.second.hasPosition() && p.second.bottom() > 0;
-	                  });
-	return make_pair(it->first, &it->second);
-}
-
 pair<pit_type, ParagraphMetrics const *> TextMetrics::last() const
 {
 	LBUFERR(!par_metrics_.empty());
diff --git a/src/TextMetrics.h b/src/TextMetrics.h
index 1a19b42939..d5606b610a 100644
--- a/src/TextMetrics.h
+++ b/src/TextMetrics.h
@@ -50,8 +50,6 @@ public:
 	///
 	std::pair<pit_type, ParagraphMetrics const *> first() const;
 	///
-	std::pair<pit_type, ParagraphMetrics const *> firstVisible() const;
-	///
 	std::pair<pit_type, ParagraphMetrics const *> last() const;
 	/// is this row the last in the text?
 	bool isLastRow(Row const & row) const;


More information about the lyx-cvs mailing list