[LyX/2.4.x] Remove setBuffer call in Cursor::push.

Jean-Marc Lasgouttes lasgouttes at lyx.org
Fri Jul 5 10:34:45 UTC 2024


commit 46d1d6e0d384bea969a55426bef22e03bc231bf8
Author: Richard Kimberly Heck <rikiheck at lyx.org>
Date:   Sat Jun 1 12:06:13 2024 -0400

    Remove setBuffer call in Cursor::push.
    
    This is potentially slow. It also should be unnecessary after
    some of JMarc's recent commits. See bug #13050.
    
    (cherry picked from commit 66cfc6af3c764b6923aae6c134c43c2155317c6a)
---
 src/Cursor.cpp | 3 ++-
 status.24x     | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/Cursor.cpp b/src/Cursor.cpp
index 45ae34c4b2..b235200db9 100644
--- a/src/Cursor.cpp
+++ b/src/Cursor.cpp
@@ -903,7 +903,8 @@ void Cursor::pop()
 void Cursor::push(Inset & inset)
 {
 	push_back(CursorSlice(inset));
-	inset.setBuffer(*buffer());
+	// See bug #13050
+	// inset.setBuffer(*buffer());
 }
 
 
diff --git a/status.24x b/status.24x
index e982adeca2..b6304efe40 100644
--- a/status.24x
+++ b/status.24x
@@ -52,6 +52,8 @@ What's new
 - Fix bug where the dialog asking for saving unapplied changes on buffer change
   popped up twice, or sometimes not at all (bug 12954).
 
+- Improve performance when selecting text on less powerful systems (bug 13050).
+
 
 * INTERNALS
 


More information about the lyx-cvs mailing list