[LyX/master] Remove dead comment

Richard Kimberly Heck rikiheck at lyx.org
Fri Nov 6 16:01:14 UTC 2020


commit 97ecf71016d05246080488260e895e36da57c0fc
Author: Richard Kimberly Heck <rikiheck at lyx.org>
Date:   Fri Nov 6 11:30:02 2020 -0500

    Remove dead comment
---
 src/Buffer.cpp      |    1 -
 src/ParIterator.cpp |    8 ++++----
 src/ParIterator.h   |    2 +-
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index a6afadf..23f6315 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -3726,7 +3726,6 @@ void Buffer::Impl::updateMacros(DocIterator & it, DocIterator & scope)
 	while (it.pit() <= lastpit) {
 		Paragraph & par = it.paragraph();
 
-		// FIXME Can this be done with the new-style iterators?
 		// iterate over the insets of the current paragraph
 		for (auto const & insit : par.insetList()) {
 			it.pos() = insit.pos;
diff --git a/src/ParIterator.cpp b/src/ParIterator.cpp
index 8086d2f..09cee80 100644
--- a/src/ParIterator.cpp
+++ b/src/ParIterator.cpp
@@ -134,14 +134,14 @@ ParagraphList const & ParConstIterator::plist() const
 	return text()->paragraphs();
 }
 
-#if 0
 bool operator==(ParConstIterator const & iter1, ParConstIterator const & iter2)
 {
-	// FIXME: this makes two full copies!
-	return DocIterator(iter1) == DocIterator(iter2);
+	DocIterator const * dit1 = &iter1;
+	DocIterator const * dit2 = &iter2;
+	return *dit1 == *dit2;
 }
 
-
+#if 0
 bool operator!=(ParConstIterator const & iter1, ParConstIterator const & iter2)
 {
 	return !(iter1 == iter2);
diff --git a/src/ParIterator.h b/src/ParIterator.h
index f1e2752..e67732f 100644
--- a/src/ParIterator.h
+++ b/src/ParIterator.h
@@ -115,7 +115,7 @@ public:
 	ParagraphList const & plist() const;
 };
 
-//bool operator==(ParConstIterator const & it1, ParConstIterator const & it2);
+bool operator==(ParConstIterator const & it1, ParConstIterator const & it2);
 
 //bool operator!=(ParConstIterator const & it1, ParConstIterator const & it2);
 


More information about the lyx-cvs mailing list