[LyX/master] Fix Qt deprecation warn for setConfirmOverwrite()

Scott Kostyshak skostysh at lyx.org
Fri Mar 6 14:37:25 UTC 2020


commit 1045020e05f926bbfdddf3e4fd0c2735bbbee2d4
Author: Scott Kostyshak <skostysh at lyx.org>
Date:   Fri Mar 6 09:18:59 2020 -0500

    Fix Qt deprecation warn for setConfirmOverwrite()
    
    Fix the following warning:
    
      error: ‘void QFileDialog::setConfirmOverwrite(bool)’ is deprecated: Use setOption(DontConfirmOverwrite, !enabled) instead [-Werror=deprecated-declarations]
    
    Note in the change that "false" changes to "true" because the option
    is *Dont*ConfirmOverwrite.
    
    QFileDialog::setConfirmOverwrite() is obsolete at least since 4.8
    and QFileDialog::setOption() is available since 4.5 [1].
    
    [1] https://doc.qt.io/archives/qt-4.8/qfiledialog-obsolete.html
    [2] https://doc.qt.io/qt-5/qfiledialog.html#setOption
---
 src/frontends/qt/FileDialog.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/frontends/qt/FileDialog.cpp b/src/frontends/qt/FileDialog.cpp
index f4bc5fd..fb05f43 100644
--- a/src/frontends/qt/FileDialog.cpp
+++ b/src/frontends/qt/FileDialog.cpp
@@ -102,7 +102,7 @@ FileDialog::Result FileDialog::save(QString const & path,
 		LyXFileDialog dlg(title_, path, filters, private_->b1, private_->b2);
 		dlg.setFileMode(QFileDialog::AnyFile);
 		dlg.setAcceptMode(QFileDialog::AcceptSave);
-		dlg.setConfirmOverwrite(false);
+		dlg.setOption(QFileDialog::DontConfirmOverwrite, true);
 		if (selectedFilter != 0 && !selectedFilter->isEmpty())
 			dlg.selectNameFilter(*selectedFilter);
 


More information about the lyx-cvs mailing list