Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

[Scott Kostyshak]

On Fri, Mar 20, 2020 at 03:08:20PM +0100, Jean-Marc Lasgouttes wrote:
> Le 20/03/2020 à 14:49, Scott Kostyshak a écrit :
> > > I would say that we don't care, so width() is better since is is shorter and
> > > easier to understand :)
> > 
> > Just to double-check: By width() you mean boundingRect().width(), and
> yes
> > you are saying it is shorter than horizontalAdvance() because we do not
> > have to condition on the Qt version, right? I agree that
> > boundingRect().width() is easier to understand than horizontalAdvance().
> 
> To be frank, I forgot about Qt version. My point was more about code being
> easier to understand.

Agreed. Done at 35bb9cb4.

> I had to read the docs to understand what the meaning
> of "horizontal advance" could be.

Same for me. I had to read them 5 times and study the pictures :)

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200320/a963aa56/attachment-0001.asc>