[RFC][PATCH] Change to GuiView::goToFileRow

Enrico Forestieri forenr at lyx.org
Sun Feb 16 21:02:32 UTC 2020


On Sun, Feb 16, 2020 at 09:28:57PM +0100, Stephan Witt wrote:
> Am 16.02.2020 um 17:54 schrieb Enrico Forestieri <forenr at lyx.org>:
> > 
> > On Sun, Feb 16, 2020 at 02:52:52PM +0100, Stephan Witt wrote:
> >> 
> >> The latest version of the mentioned patch I’ve used for 1. and 2. is
> > 
> > Thank you. It is surprising that only for the Mac absPath() expands
> > symlinks. Anyway, I think I now understand the problem.
> > 
> > Please, can you report whether the attached patch works for you
> > irrespectively of the Qt version?
> 
> Yes, it works too. But did you have any problem with my patch 
> or do you think it’s not good?

No, it's simply that I think the previous code is easier to follow.

> I have to admit I like mine more.

;-)

> Especially the subst part of the original code formally isn’t 100% correct.

Why?

-- 
Enrico


More information about the lyx-devel mailing list