[RFC][PATCH] Replace deprecated mem_fun_ref with lambda
lasgouttes at lyx.org
Thu Feb 13 17:26:59 UTC 2020
Le 13/02/2020 à 18:03, Pavel Sanda a écrit :
> On Wed, Feb 12, 2020 at 08:45:06PM +0100, Jean-Marc Lasgouttes wrote:
>> I replace a thing I do not really understand with another thing that I do
>> not really understand either. Can someone tell me whether the use o lambda
>> expression is OK? I do not know how to test it.
> I would be more happy to just rewrite it with a normal loop.
> - Lambda expression will break older gcc's and I do not find that fortunate
> at the very end of development cycle.
This is C++11 code, which should be completely OK. What you have to
rewrite was C++14-only code.
> - Comitting code which neither of us can fluently read does not seem as a good
> idea either unless we want to force ourselves to start using lambdas in general.
I tend to agree. I do not find these idioms clearer (especially with the
ugly thing.begin(), thing.end()) and I do not believe that they are
faster. What is the point actually?
More information about the lyx-devel