Comments on patch for paragraph-move-down to move sub-items as well

Scott Kostyshak skostysh at
Mon Feb 3 02:36:59 UTC 2020

On Sun, Feb 02, 2020 at 08:36:53PM -0500, Scott Kostyshak wrote:

> The logic in RandomAccessList is overly
> complicated (and inefficient) and I'm working on simplifying it by using
> a splice instead of all of those swaps.

The attached patch implements the splice approach. I've tested the patch
in a few situations and it works well. With the splice approach it is
now efficient and the logic is cleaner. However, the patch uses a
special case that is not elegant for when the next sibling is at the end
of the document. I cannot seem to use iterCont_ for the last paragraph
in this case. The cases could probably be combined but I don't have a
good understanding of RandomAccessList.

I don't expect anyone to take a look but I post it just in case.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Paragraph-move-down-now-moves-sub-items-as-well.patch
Type: text/x-diff
Size: 3195 bytes
Desc: not available
URL: <>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <>

More information about the lyx-devel mailing list