[patch] Refresh previews on branch toggle?

Kornel Benko kornel at lyx.org
Mon Dec 9 08:39:33 UTC 2019

Am Sun, 8 Dec 2019 23:03:20 -0500
schrieb Richard Kimberly Heck <rikiheck at lyx.org>:

> On 12/8/19 9:20 PM, Scott Kostyshak wrote:
> > Attached is a patch that refreshes previews whenever the user activates
> > or deactivates a branch. The motivation for this patch is that if a
> > child document is previewed in the master document, and if the child
> > document has the branch inside it as well, the preview will be incorrect
> > when the branch is toggled (without this patch).
> >
> > However, this patch will cause all previews to refresh. I'm concerned
> > that the inefficiency is not worth the benefit. Any thoughts on this
> > patch and any thoughts on an ideal solution? For example, would
> > removePreviews() and updatePreviews() ideally have arguments that allow
> > to specify which type of previews to update?  
> It makes sense to me.

To me too.

> Do we have to remove previews first?
> Riki

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20191209/1940b365/attachment-0001.asc>

More information about the lyx-devel mailing list