[patch] Refresh previews on branch toggle?

Scott Kostyshak skostysh at lyx.org
Mon Dec 9 02:20:30 UTC 2019


Attached is a patch that refreshes previews whenever the user activates
or deactivates a branch. The motivation for this patch is that if a
child document is previewed in the master document, and if the child
document has the branch inside it as well, the preview will be incorrect
when the branch is toggled (without this patch).

However, this patch will cause all previews to refresh. I'm concerned
that the inefficiency is not worth the benefit. Any thoughts on this
patch and any thoughts on an ideal solution? For example, would
removePreviews() and updatePreviews() ideally have arguments that allow
to specify which type of previews to update?

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Refresh-previews-on-branch-toggle.patch
Type: text/x-diff
Size: 1564 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20191208/2ed4d948/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20191208/2ed4d948/attachment.asc>


More information about the lyx-devel mailing list