[LyX/master] Mark insets with invalid buffer() in red in devel-mode.

Richard Kimberly Heck rikiheck at lyx.org
Tue Oct 22 01:33:03 UTC 2019


On 10/21/19 12:43 PM, Jean-Marc Lasgouttes wrote:
> Le 21/10/2019 à 18:13, Richard Kimberly Heck a écrit :
>>>      To this end, a new method develMode() is added to the Painter
>>> class.
>>>           With this commit, it is easy to see that macro template do
>>> not have a
>>>      proper buffer set!
>>
>> I was thinking to try adding inset().setBuffer() to the beginning of
>> updateBuffer() in master, as we discussed before, and see what happens.
>> And if that goes well, then to start removing manual setBuffer() calls
>> in various places, and see how that goes. Thoughts?
>
> Sure, if we are sure that this propagates everywhere. But are we sure
> that we will never have to access buffer() before updateBuffer has
> been run on the whole document?

Only one way to find out...

More seriously, I think we /shoudn't/ be doing anything that accesses
buffer() before then, though there are some cases where we do. I think
there is such a case in the cut and paste code, though I'm not sure.

Riki


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20191021/052dd104/attachment.html>


More information about the lyx-devel mailing list