[LyX/master] Transform simple search dialog to dock widget (#2625)

Stephan Witt st.witt at gmx.net
Sun Feb 14 18:52:27 UTC 2021


Am 14.02.2021 um 19:33 schrieb Jean-Marc Lasgouttes <lasgouttes at lyx.org>:
> 
> Le 14/02/2021 à 18:39, Stephan Witt a écrit :
>> So the attached patch helps. I’d like to apply it.
> 
> -	BufferView const * bv_;
> +	BufferView const * bv_ = {};
> 
> I am a bit surpisez by these fluctoating notations. Am I right that it is the same to write:
> BufferView const * bv_ {};
> BufferView const * bv_ = {};
> BufferView const * bv_ = {nullptr};
> BufferView const * bv_ = nullptr;
> 
> Why do we need to have all these possibilities? In particular the first one is weird to me.
> 
> Is there a reason why initializing to {} eems better than initializing to nullptr? Isn't the later more explicit?

My first attempt was the 4th variant.

Yes, it’s a matter of style and I’m ok with this too.

Latest changes made me think it’s more modern to use the {} syntax.

Stephan

> 
> I am asking, because this is probably something that belongs to our code rules.
> 
> JMarc
> -- 
> lyx-devel mailing list
> lyx-devel at lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel



More information about the lyx-devel mailing list