Bookmark Marker Weirdness

[Jean-Marc Lasgouttes]

Le 11/03/2021 à 16:26, Jürgen Spitzmüller a écrit :
>> Do you lean that inline could be better now that drifting is fixed?
> 
> Yes, as it more precisely indicates the position.

So, it would mean that we want the attached pair of patches.

Testing appreciated, I would like to avoid going back and forth in master.

Note that a consequence of the visualization is that bookmarks bugs 
become more obvious. Simple example :

1. set a bookmark in a paragraph,
2. modify the paragraph,
3. undo
-> the bookmark disappears.

This is because the paragraph id dies in the operation. A fix is coming 
soon for this.

Of course, if the paragraph id is not found, the bookmark should instead 
be shown in the top level paragraph. I do not know yet how to do that, 
but it is doable.

So there are two solutions now:

1/ revert bookmark display now, implement it in 2.5.0dev and fix the 
issues that this reveals. I anticipate that most of the issues will be 
easy to solve.

2/ keep the inline version, and deal with the incoming bug reports, that 
will be about bugs which actually already existed.

Riki, Jürgen, What would you prefer?

JMarc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-Display-bookmarks-in-the-workarea-take-2.patch
Type: text/x-patch
Size: 7162 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210403/c628e22e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Revert-Revert-Display-bookmarks-in-the-workarea.patch
Type: text/x-patch
Size: 6434 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210403/c628e22e/attachment-0001.bin>