DocBook v2

[Scott Kostyshak]

On Sun, Sep 13, 2020 at 12:05:21AM +0200, Thibaut Cuvelier wrote:
> On Sat, 12 Sep 2020 at 21:17, Scott Kostyshak <skostysh at lyx.org> wrote:
> 
> > On Sat, Sep 12, 2020 at 09:01:14PM +0200, Thibaut Cuvelier wrote:
> > > On Sat, 12 Sep 2020 at 18:53, Scott Kostyshak <skostysh at lyx.org> wrote:
> >
> > > > > I tried to add quotes in Layout::write,
> > > >
> > > > Good idea.
> > > >
> > > > > maybe this is enough to fix the
> > > > > issue? (Amended commit: b2881c27.)
> > > >
> > > > The tests still fail, but now give output like the following:
> > > >
> > > > LyX: Unknown layout tag `sect1""' [around line 43 of file  current
> > token:
> > > > 'sect1""' context: '']
> > > > Could not read style Section*.
> > > > LyX: Unknown layout tag `sect2""' [around line 43 of file  current
> > token:
> > > > 'sect2""' context: '']
> > > > Could not read style Subsection*.
> > > > LyX: Unknown layout tag `sect3""' [around line 43 of file  current
> > token:
> > > > 'sect3""' context: '']
> > > > Could not read style Subsubsection*.
> > > > LyX: Unknown layout tag `sect4""' [around line 43 of file  current
> > token:
> > > > 'sect4""' context: '']
> > > > Could not read style Paragraph*.
> > > > LyX: Unknown layout tag `sect5""' [around line 44 of file  current
> > token:
> > > > 'sect5""' context: '']
> > > > Could not read style Subparagraph*.
> > > > <end of output>
> > > >
> > >
> > > This issue should be resolved: in these styles, there were already quotes
> > > in DocBookAttr.
> >
> > Looks good! There are now only three layout tests that fail:
> > aastex.layout, aastex6.layout, and aastex62.layout. They all give the same
> > error:
> >
> > LyX: Unknown layout tag `alternate""' [around line 48 of file  current
> > token: 'alternate""' context: '']
> >
> 
> That should be fixed too :)!

Looks good! All "check_layout" tests pass and all "docbook5" tests
(still) pass. Thanks for all of the quick fixes.

> (There were also issues with shapepar.module,
> by the way.)

Good to know. The tests didn't fail for shapepar.module so I guess we
don't have coverage for that type of error for some reason.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200912/6c8deddb/attachment.asc>