DocBook v2

[Scott Kostyshak]

On Fri, Sep 11, 2020 at 02:01:24PM +0200, Thibaut Cuvelier wrote:

> I've made a better fix: actually, this was just a typo :). All the relevant
> commits have been squashed into 0a7c29c9b567518d26a378759846e892b33d2925.

Tested and works well!

> 79712827c9bb4534c4649d3dc67c35ad64bc3b6e simplifies the code further (it's
> basically an amendment to 0a7c29c9b567518d26a378759846e892b33d2925). I hope
> it does not create new problems for you!
> 
> As expected, though, the old DocBook layouts produce warnings like this:
> 
> Layout file D:/LyX/lyx-unstable/lib\layouts\docbook-book.layout has no
> \DeclareLaTeXClass line.
> Layout file D:/LyX/lyx-unstable/lib\layouts\docbook-chapter.layout has no
> \DeclareLaTeXClass line.
> Layout file D:/LyX/lyx-unstable/lib\layouts\docbook-section.layout has no
> \DeclareLaTeXClass line.
> 
> In my opinion, it's not really a problem, as the \DeclareDocBookClass has
> no more effect: if a user had such a layout, they will get a warning about
> it, which is nice.

Makes sense, good to know.

>> By the way, what would you prefer I do in this
> > case where I'm not sure the fix is correct? Since we're on a branch, I
> > just committed so that way the tests work for me and Kornel (who I
> > imagine is also affected by this configure issue). But if you prefer I
> > post the patch to the list instead of pushing, that's fine too. In my
> > opinion, since it's your branch you should choose the workflow.
> >
> 
>  I have no problem with you pushing commits onto that branch. Just make
> sure to send the hash on the list, in case I make one force push too many
> :).

Sounds good! I will try to remember to always specify the hash (please
let me know if I forget).

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200911/5e9caa86/attachment.asc>