Text selection does not work as expected

[Scott Kostyshak]

On Thu, Sep 10, 2020 at 08:00:04PM +0200, Yu Jin wrote:
> Am Do., 9. Juli 2020 um 10:12 Uhr schrieb Daniel <xracoonx at gmx.de>:
> 
> > On 2020-07-09 09:39, Yu Jin wrote:
> > > Am Mi., 8. Juli 2020 um 23:31 Uhr schrieb Scott Kostyshak
> > > <skostysh at lyx.org <mailto:skostysh at lyx.org>>:
> > >
> > >     On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote:
> > >
> > >      > Here we go, patch attached. I decided to put Qt version check
> > 5.10.1,
> > >      > because I have tested it on LyX 2.3.1, which was shipped with Qt
> > >     5.10.1 and
> > >      > the bug was not there yet.
> > >
> > >     Your patch is perfect, Eugene. Thanks! Please commit.
> > >
> > >     One minor typo: "wuickly" should be "quickly".
> > >
> > >     Thanks for your Qt bug report. I know it takes time to make a minimal
> > >     example and post it. It looks like they're taking a look and already
> > >     it's good to know that it can't be reproduced on macOS.
> > >
> > >
> > > Ok done, I will keep an eye on it on the Qt bugtracker and will send an
> > > Email once it has been fixed.
> > > Thanks for the report, Daniel.
> > >
> > > Eugene
> >
> > Thanks. And thank you both for following up on it!
> >
> 
> Qt 5.15.1 is released today, I have compiled master using that version
> while the fixing commit was reverted. As expected, the text selection is
> behaving as expected. Means the bug is fixed. I have attached a patch for
> review.

Looks good. I suggest you push.

> Another possibility would ofc be to revert the original commit
> (06969f9d).

I have a slight preference for you to push the patch. I think that we go
through those version guards and remove them after LyX requires a
minimum Qt version with the fix. That is, once we require at least Qt
5.15.1 as a version, then we can remove this specific instance of the
guards. We won't require 5.15.1 for a long time (I hope!). If you have a
preference to revert the original commit though, we should discuss it.

Nice work getting a Qt bug fixed!

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200910/87dceea2/attachment.asc>