CMake file and Visual C++ choking on LYX_WALL

[Thibaut Cuvelier]

Dear list,

I just tried to enable more warnings with Visual C++. According to
INSTALL.cmake, it should be enough to set LYX_WALL to 1, but I get these
warnings from the compiler:

cl : Command line warning D9002 : ignoring unknown option 'Wp64'

In CMakeLists.txt:1091 to 1093, I indeed find that, with LYX_WALL, the
parameter /Wp64 is used (it was deleted a few years ago:
https://docs.microsoft.com/en-us/cpp/build/reference/wp64-detect-64-bit-portability-issues?view=vs-2019
).

The right flag is the one indicated in the documentation: /W4. Making the
change locally seems to be right (VC returns more warnings for the code and
none for its arguments).

Was this /Wp64 intentional? It really seems odd there… In any case, I've
added a patch for this fix, if it is welcome.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200902/808f72d6/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LYX_WALL.patch
Type: application/octet-stream
Size: 1177 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200902/808f72d6/attachment.obj>