--std=c++11 fails on master

[Kornel Benko]

Am Tue, 27 Oct 2020 02:49:18 -0400
schrieb Richard Kimberly Heck <rikiheck at lyx.org>:

> On 10/26/20 10:49 PM, Scott Kostyshak wrote:
> > On Mon, Oct 26, 2020 at 09:32:33AM +0200, Yuriy Skalko wrote:  
> >>> I have the following:
> >>>
> >>> #define HAVE_DEF_MAKE_UNIQUE 1
> >>>
> >>> Here is the diff I am using to force C++11:
> >>>
> >>> diff --git a/development/cmake/modules/FindCXX11Compiler.cmake
> >>> b/development/cmake/modules/FindCXX11Compiler.cmake
> >>> index f9a1aaf045..b990191424 100644
> >>> --- a/development/cmake/modules/FindCXX11Compiler.cmake
> >>> +++ b/development/cmake/modules/FindCXX11Compiler.cmake
> >>> @@ -57,8 +57,6 @@ else()
> >>>  # Detection of c++20 works well, but our code is not ready for it yet.
> >>>  # We currently get errors with internal boost and also from our code.
> >>>  #        "--std=c++20"
> >>> -        "--std=c++17"
> >>> -        "--std=c++14"
> >>>          "--std=c++11"
> >>>          "--std=gnu++11"
> >>>          "--std=gnu++0x"
> >>>
> >>> Scott  
> >> So that's why it gives compilation error. As I said before
> >> HAVE_DEF_MAKE_UNIQUE should be inactive in C++11 mode. Have you tried to
> >> remove CMake cache as Kornel suggested?  
> > I did not try to remove the CMake cache, but Kornel sent me a patch that
> > seems to work.  
> 
> Is this a patch we need in master?
> 
> Riki
> 
> 

Not really. As it is (without forcing only c++11) it is still OK.

I plan to do something here for the beta release.

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201027/2b5fdeb9/attachment.asc>