Changers

[Yuriy Skalko]

>> I cannot reproduce this in my GCC 7.3 even in C++11 mode (by default it
>> compiles in C++17 with CMake build). Please check if this helps:
> 
> 
> This helps indeed.

Committed.

>> By the way, what is the oldest supported GCC? README says it is GCC 4.7. Is
>> it right?
> 
> I think that for LyX 2.4 is reasonable to bump at least to gcc 4.8, because
> 4.7 does not have full support for C++11 yet. I am personally compiling
> with 4.9, so unless someone trumps me with lower version we should state
> 4.9 in README.
> 
> Pavel

It was 4.7 in README and 4.8 in INSTALL, so I bumped it to 4.9 everywhere :)


> +1
> we should also mention it in lib/RELEASE-NOTES.
> 
> Scott

I'm not sure about section to add this. Please amend the attached patch.


Yuriy
-------------- next part --------------
From d72580682131d7ed9360bc14dec4638982abc686 Mon Sep 17 00:00:00 2001
From: Yuriy Skalko <yuriy.skalko at gmail.com>
Date: Sun, 15 Nov 2020 22:34:04 +0200
Subject: [PATCH 2/3] Bump minimal GCC version to 4.9

---
 INSTALL | 2 +-
 README  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/INSTALL b/INSTALL
index 2861d7b1e8..6f26ee229c 100644
--- a/INSTALL
+++ b/INSTALL
@@ -53,7 +53,7 @@ Requirements
 ------------
 
 First of all, you will need a C++11 standard conforming compiler, like gcc (at
-least 4.8) or clang.
+least 4.9) or clang.
 
 LyX makes great use of the C++ Standard Template Library (STL).
 This means that gcc users will have to install the relevant libstdc++
diff --git a/README b/README
index 222a9932a5..a0a44dc75b 100644
--- a/README
+++ b/README
@@ -88,7 +88,7 @@ What do I need to compile LyX from the source distribution?
 
     * A C++11 compiler. Development is being done mainly with gcc/g++,
       but clang and MSVC are known to work too. As of LyX 2.4.0, you
-      need at least gcc 4.7.
+      need at least gcc 4.9.
 
     * The Qt library, at least version 5.2 (5.6 recommended). It is
       still possible to compile with Qt 4.8, but this is not
-- 
2.28.0.windows.1