[Patch] Test suite for compare function

Pavel Sanda sanda at lyx.org
Sun Nov 15 09:38:33 UTC 2020


On Sat, Nov 14, 2020 at 11:28:43AM -0500, Richard Kimberly Heck wrote:
> On 11/13/20 8:24 PM, Scott Kostyshak wrote:
> > On Sat, Nov 14, 2020 at 01:43:08AM +0100, Kornel Benko wrote:
> >> Am Sat, 14 Nov 2020 13:22:39 +1300
> >> schrieb "Sam Crawley" <sam at crawley.nz>:
> >>
> >>> On Sat, 14 Nov 2020, at 12:36, Kornel Benko wrote:
> >>>>> Defined at development/checkurls/CMakeLists.txt:8
> >>>>> find_package(Perl REQUIRED)
> >>>>>
> >>>>> Apparently you do not have '-DLYX_ENABLE_URLTESTS:BOOL=ON'. We should move the
> >>>>> find_package() call to different place, maybe to the main CMakeLists.txt.
> >>>>>
> >>>>> Kornel  
> >>>> Hm, done at 5680a4d3.  
> >>> Thanks, that fixed it!
> >>>
> >>> Updated patchset attached.
> >>>
> >>> Thanks,
> >>> Sam.
> >> Thanks, test works.
> >> From my side, it can be committed. Any objections?
> >> Pavel, Jean-Marc, Riki, Scott?
> > I did not take a look, but I do not have any objection. If it's fine
> > with you it's fine with me.
> 
> +1

Committed. Pavel


More information about the lyx-devel mailing list