[Patch] Test suite for compare function

Scott Kostyshak skostysh at lyx.org
Sat Nov 14 01:24:14 UTC 2020


On Sat, Nov 14, 2020 at 01:43:08AM +0100, Kornel Benko wrote:
> Am Sat, 14 Nov 2020 13:22:39 +1300
> schrieb "Sam Crawley" <sam at crawley.nz>:
> 
> > On Sat, 14 Nov 2020, at 12:36, Kornel Benko wrote:
> > > > 
> > > > Defined at development/checkurls/CMakeLists.txt:8
> > > > find_package(Perl REQUIRED)
> > > > 
> > > > Apparently you do not have '-DLYX_ENABLE_URLTESTS:BOOL=ON'. We should move the
> > > > find_package() call to different place, maybe to the main CMakeLists.txt.
> > > > 
> > > > Kornel  
> > > 
> > > Hm, done at 5680a4d3.  
> > 
> > Thanks, that fixed it!
> > 
> > Updated patchset attached.
> > 
> > Thanks,
> > Sam.
> 
> Thanks, test works.
> From my side, it can be committed. Any objections?
> Pavel, Jean-Marc, Riki, Scott?

I did not take a look, but I do not have any objection. If it's fine
with you it's fine with me.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201113/fa805373/attachment.asc>


More information about the lyx-devel mailing list