Changers

[Jean-Marc Lasgouttes]

Le 11/11/2020 à 13:08, Yuriy Skalko a écrit :
>>>  Now I've found that Changer is just no-op variant of RefChanger. 
>>> Their separation into different headers confused me. 
>>
>>
>> Isn't it just some type of abstract base class?
>>
>> JMarc
> 
> Yes, it is base class, but it cannot be abstract because it is used in 
> client code for no-change cases.
> 
> I've tried to simplify and make Changers implementation more consistent 
> and located in one place. Please check the attached patch.

Why not, I like the idea of having everything in the same header. Then I 
would rename make_change() to no_change() and even maybe introduce 
something like make_change_if(cond, var, value), but I am not sure about 
this last idea (or another name like maybe_change or cond_change, or...).


JMarc