[LyX/master] Improve structure of updateMacros

[Richard Kimberly Heck]

On 11/11/20 9:36 AM, Kornel Benko wrote:
> Am Tue, 10 Nov 2020 01:05:12 -0500
> schrieb Scott Kostyshak <skostysh at lyx.org>:
>
>> On Fri, Nov 06, 2020 at 08:05:10PM +0100, Yuriy Skalko wrote:
>>> commit 5a54ccfa87057fd3220d7193b40ac2dd37a9e6e1
>>> Author: Yuriy Skalko <yuriy.skalko at gmail.com>
>>> Date:   Wed Nov 4 11:27:08 2020 +0200
>>>
>>>      Improve structure of updateMacros
>>> ---
>> A git bisect suggests this commit broke the following ctest:
>>
>>    export/doc/es/Additional_xhtml
>>
>> To reproduce manually, open the file lib/doc/es/Additional.lyx
>> and do File > Export > LyXHTML. On current master I get a SIGSEGV.
>>
>> By the way, thank you for all of the cleaning up and refactoring work!
>>
>> Scott
> In /usr2/src/lyx/lyx-git/src/Buffer.cpp:3898
> 	if (d->macro_lock)
> SIGSEGV, Segmentation fault.
> (gdb) p d
> Cannot access memory at address 0x48
> (gdb) p *this
> Cannot access memory at address 0x0
> (gdb) up
> #1  0x00005555568a498d in lyx::InsetMathHull::preparePreview (this=0x55555a673ce0,
> pos=..., forexport=true) at /usr2/src/lyx/lyx-git/src/mathed/InsetMathHull.cpp:809
> 809		buffer->listMacroNames(macros);
> (gdb) p macros
> $1 = {<std::__debug::set<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>,
> std::allocator<wchar_t> >, std::less<std::__cxx11::basic_string<wchar_t,
> std::char_traits<wchar_t>, std::allocator<wchar_t> > >,
> std::allocator<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>,
> std::allocator<wchar_t> > > >> = std::__debug::set with 0 elements, <No data fields>}
> (gdb) p macros.size()
> $2 = 0
> (gdb)

I've reverted this commit. It's one case where using inset codes gets 
the wrong result.

Riki