[LyX/2.3.x] Use data from src/lyxwinres.rc to generate lyx.coff for the Windows build.

[Kornel Benko]

Am Tue, 16 Jun 2020 16:37:11 +0200
schrieb Yu Jin <yu_jin at lyx.org>:

> Am Mo., 15. Juni 2020 um 18:03 Uhr schrieb Kornel Benko <kornel at lyx.org>:
> 
> > Am Mon, 15 Jun 2020 09:51:30 -0400
> > schrieb Scott Kostyshak <skostysh at lyx.org>:
> >
> > > On Mon, Jun 15, 2020 at 08:24:07AM +0200, Kornel Benko wrote:
> > > > Am Sun, 14 Jun 2020 22:01:20 -0400
> > > > schrieb Scott Kostyshak <skostysh at lyx.org>:
> > > >
> > > > > On Fri, Dec 27, 2019 at 09:14:51PM -0500, Scott Kostyshak wrote:
> > > > > > On Wed, Jun 19, 2019 at 07:50:26PM +0200, Kornel Benko wrote:
> > > > > > > Am Dienstag, 18. Juni 2019, 23:42:19 CEST schrieb Richard
> > Kimberly Heck:
> > > > > > > > commit 446769203f157ef5ff964e6d7355f840c8c91cac
> > > > > > > > Author: Richard Kimberly Heck <rikiheck at lyx.org>
> > > > > > > > Date:   Tue Jun 18 17:50:19 2019 -0400
> > > > > > > >
> > > > > > > >     Use data from src/lyxwinres.rc to generate lyx.coff for
> > the Windows
> > > > > > > >     build.
> > > > > > > >
> > > > > > > >     Ideally, this would be done by cmake itself (as it is now
> > done by
> > > > > > > >     autotools). But I do not know how to do that.
> > > > > > > > -
> > > > > > >
> > > > > > > Something like following ... alas I cannot test. For sure, I
> > don't know the
> > > > > > > value of "${CPP}"
> > > > > >
> > > > > > I don't know anything about this but thought I would bump it since
> > there
> > > > > > seems to be a (partial?) patch. Riki is this something that you can
> > > > > > test?
> > > > >
> > > > > Kornel, is this patch still relevant? If so maybe we can ask Eugene
> > to
> > > > > take a look and test?
> > > > >
> > > > > Scott
> > > >
> > > > I do not remember. Somehow my own mail with this subject got lost.
> > >
> > > It is here:
> > >
> > >   https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg209035.html
> > >
> > > It was in response to Riki's commit 44676920 (which does not show up
> > > since it was sent to lyx-cvs).
> > >
> > > Scott
> >
> > Aha. Thanks. Asking Eugene is certainly an option.
> >
> 
> Isn't changeset d537d55b6955bddb55e5dff9c4b6ad34fb53d2b7
> <https://www.lyx.org/trac/changeset/d537d55b6955bddb55e5dff9c4b6ad34fb53d2b7/lyxgit>
> related to that somehow?

Totally unrelated. The above is about interpreting the lyx-version-numbers.

> lyx.rc in master declares only the icon though.

> Eugene

If you feel that everything works for icons on Windows, then we can ignore the patch.
OTOH, it was Riki who wanted to interpret src/lyxwinres.rc ...

	Kornel


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200616/8848b7bc/attachment-0001.asc>