Work on Windows installer

Kornel Benko kornel at lyx.org
Mon Jun 1 13:43:00 UTC 2020


Am Mon, 1 Jun 2020 14:56:47 +0200
schrieb Yu Jin <technikmagma at gmail.com>:

> Am Mo., 1. Juni 2020 um 14:01 Uhr schrieb Kornel Benko <kornel at lyx.org>:0
> 
> > From what I can see, the patch adds only Windows install in extra dir.
> >
> > The duplication of language-files
> >         development/Win32/packaging/installer2/src/lang/*.nsh
> > vs
> >         development/Win32/packaging/installer/lang/*.nsh
> >
> > looks not so pleasant. Do we really have to expect different translations
> > in
> > these directories?
> >
> 
> The translations should be exactly the same, I did not change any strings.
> Why I made a second lang dir though isdevelopment/Win32/packaging/, mainly because of
> the strings $(EnterLaTeXFolder) and $(EnterLaTeXFolderNone). In the current Installer
> they write new lines as "\r\n", I had to change that to "$\r$\n" (NSIS
> conform) due to recreating the custom LatexFolder page with NSDialogs
> plugin in NSIS Dialog Designer (currently done with deprecated
> InstallOptions plugin). And these 2 strings are actually the only strings
> to use "\r\n" instead of "$\r$\n" currently. I also removed some variables
> and compile time constants and had to adapt the strings to that.
> 
> Eugene

Instead of changing strings, it should be possible to change the handling of
the translatable strings (e.g. replace "\r\n" to "$\r$\n" on the fly)

The position of these files could be
	development/Win32/packaging/installerCommon/lang/*.nsh
to be used by both installers.

	Kornel
	
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200601/161cb8fd/attachment.asc>


More information about the lyx-devel mailing list