New DocBook support (0005)

[Thibaut Cuvelier]

On Sun, 5 Jul 2020 at 11:59, Pavel Sanda <sanda at lyx.org> wrote:

> On Sat, Jul 04, 2020 at 12:42:31AM +0200, Thibaut Cuvelier wrote:
> > From f7004ab6518c230f6cedd89410d9059e9596a113 Mon Sep 17 00:00:00 2001
> > From: Thibaut Cuvelier <cuvelier.thibaut at gmail.com>
> > Date: Mon, 8 Jun 2020 23:27:49 +0200
> > Subject: [PATCH 5/9] New DocBook support
>
> Now the real beef. It's impossible to keep permanent attention given the
> length of the
> patch so this might not be all and we'll go through more iterations,
> sorry...
>

No problem, it will take the time it will need!


> BTW I really appreacite your comments verbosity esp. on more tricky parts
> of the code like
> in InsetIndex, I only wish the rest of LyX codebase was similar.
>

I often wondered if I really should comment that much, I decided it was
easier to remove comments than to understand something from scratch to add
meaningful ones :).


> Let me voice again my concern that this kind of chaining might backfire.
> operator << does not guarantee you order of evaluation, the clear case was
> the previous code like:
> xs<< (a==0?c,d) << ++a ;
> Different compilers can do either ++a first and then compare or vice versa.
>

I went through the whole patch to solve these issues (and also some
indentation ones).

I'm stopping here for now, I need a break :).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200705/6c93cc1c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-New-DocBook-support.patch
Type: application/octet-stream
Size: 221351 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200705/6c93cc1c/attachment-0001.obj>