Advanced find changes of behavior in master

[Scott Kostyshak]

On Mon, Dec 21, 2020 at 07:40:21PM +0100, Jean-Marc Lasgouttes wrote:
> Le 25/11/2020 à 15:35, Scott Kostyshak a écrit :
> > I see a couple of changes in behavior in advanced find that can be
> > reproduced with the Welcome.lyx file (I attached it for convenience).
> > 
> > 1. In advanced find, put "a" in the find area and "c" in the replace
> >     area and do "Replace all". It takes about 10 seconds with 2.3.0, and
> >     about 25 seconds with master. I remember when testing before that
> >     advanced find was much faster than 2.3.0, so if this is just a weird
> >     "worst case" scenario, then I think that's fine.
> 
> Try again, I updated the layout files, it seems to make a big difference to
> me. Then we have to know why Adv F&R has to read the class files at all
> (using cut and paste, maybe?)

Works well with the updated layouts. I no longer see a difference in
speed. Thanks.

> > 2. In 2.3.0, there are more workarea updates. This way, the user can see
> >     what is being replaced and where. In master, there is only one work
> >     area update at the end. This seems like an improvement in theory, but
> >     since the advanced find takes a while, it is kind of nice to watch it
> >     so that we know it is not stuck and can get an idea of the progress.
> >     In master, it is strange to see toolbar buttons being enabled and
> >     disabled (based on where the invisible cursor is) and the scrollbar
> >     moving, but not to see the cursor moving and the work area updates. I
> >     don't have a preference on this. I just mention it in case the change
> >     was not intended.
> 
> With the attached patch, the toolbar is not updated anymore. The scrollbar
> still moves, though, and acts as a sort of progression bar.

Tested and works well. I think it's a step forward (I suggest to commit
if you are comfortable with it).

One more issue I noticed (which I do not ask any person in particular):
I am fine if we do not move the cursor after each change. Indeed, once
we are used to it, using the scroll bar as a progress bar is intuitive.
However, I would find it more intuitive if before the "Wrap search"
dialog pops up we do one refresh of the work area with the
substitutions. I find it strange that when the dialog pops up, I do not
see any changes, even though they have been made.

> The priority should be on making things fast, though.

+1 I think Kornel's work has sped up some use cases considerably from
some tests I did a while ago. But indeed, it is still slow for many
cases.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201222/78336958/attachment.asc>