[LyX/master] Reduce the amount of needed boost headers

Jean-Marc Lasgouttes lasgouttes at lyx.org
Sat Dec 19 19:43:36 UTC 2020


Le 19/12/2020 à 20:05, Yuriy Skalko a écrit :
>> Since support/signals.h is pretty empty now, why not just use 
>> nod/signal.h and nod::signal? Then we can get rid of the header file.
>>
>>
>> Patches 2 and 4 are fine.
>>
>> JMarc
> 
> I think that it is better to leave such interfacing header to limit this 
> 3rd-party dependency in one point (this already allowed seamless 
> replacement of boost::signals2 with interface-compatible nod). Now most 
> 3rd-party dependencies of LyX (besides Qt) are isolated and included 
> only in 1-2 client header/source.

Boost is not, the others in 3rdparty are not encapsulated but used only 
in a few place.

If you want to keep a header file, the best is probably to put 
everything in namespace lyx.

JMarc


More information about the lyx-devel mailing list