Comments on "Edit externally" feature

Scott Kostyshak skostysh at lyx.org
Sun Dec 6 18:29:57 UTC 2020


On Sun, Dec 06, 2020 at 11:00:06AM -0500, Richard Kimberly Heck wrote:
> On 12/6/20 9:21 AM, Scott Kostyshak wrote:
> >
> > Strange, I still don't see the lock. Which commit fixed this?
> 
> Actually, I forgot to commit that! Should be fixed now.

Thanks, tested and works well!

One other thing I'm thinking about is: how should things work with undo?

For example, suppose I do:

1. write "abc" outside an inset (just to have something to undo *to*).
2. edit an inset externally.
3. without ending the external edit, do "undo".
4. now go to the text editor that opened after (2) and make changes and
   save and exit.

The current result, I think, is that the external edits will be lost.
I think the current behavior is reasonable, since I don't know what I
would expect. But I'm still curious what others think.

Perhaps a warning would be appropriate?

Similarly, if I edit an inset externally, and close the buffer, should we give an error like "please end your external edits before closing" or something like that?

Asynchronous features like this are so tricky to cover all the special cases.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201206/6ce71049/attachment.asc>


More information about the lyx-devel mailing list