New Defects reported by Coverity Scan for LyX

Stephan Witt st.witt at gmx.net
Tue Aug 25 09:06:53 UTC 2020


Am 25.08.2020 um 10:41 schrieb Jean-Marc Lasgouttes <lasgouttes at lyx.org>:
> 
> Le 25/08/2020 à 07:17, Stephan Witt a écrit :
>>> I would propose to either define Inset::asInsetBibitem() and use that, or rely only on dynamic_cast. But it is not necessary to rely on inset code IMO (I try to reduce the amount of such code uses, but they creep back relentlessly :).
>> So, this patch would be appreciated? :)
> 
> Well, it would be if we decided to use dynamic_cast everywhere :) Personally, my only gripe is the keyword is too long and disrupts reading of code. I would prefer
>  as<InsetSpecialChar *>(inset)
> but I understand it is a bit short :)
> 
> So feel free to apply your patch, is is more c++-ish AFAIU.

I did it.

Next patch is the real change for #6401. I’d like to apply it soon. Any objections or possible improvements?

Stephan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-6401-correct-cursor-movement-for-word-forward-backwa.patch
Type: application/octet-stream
Size: 5936 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200825/ea031873/attachment-0001.obj>


More information about the lyx-devel mailing list