Commit 957b615b (Fix another crash with Grid pasting) breaks compilation with Visual C++ 2019

Stephan Witt st.witt at gmx.net
Sun Aug 16 19:29:50 UTC 2020


Am 16.08.2020 um 21:00 schrieb Stephan Witt <st.witt at gmx.net>:
> 
> Am 16.08.2020 um 19:23 schrieb Thibaut Cuvelier <tcuvelier at lyx.org>:
>> 
>> Hi,
>> 
>> I just tried to compile the latest version of the code with Visual C++. However, it chokes on line 1637 of InsetMathGrid.cpp: 
>> 
>> error C3861: 'uint': identifier not found
>> 
>> Here is my (simple) fix, in bold (formal patch attached): 
>> pos_type ipos = pos_type(cur.pos()) > cell(i).size()
>> I preferred not to commit this directly, in case other compilers do not like this version…
>> <0001-Fix-compilation.patch>— 
> 
> Why these cast at all?
> 
> cur.pos() is returning a pos_type, AFAICS.

This patch works with clang and avoids a type mismatch warning for signed vs unsigned typed values comparison.

Stephan 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: application/octet-stream
Size: 669 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200816/2852ba62/attachment-0001.obj>


More information about the lyx-devel mailing list