Depthbar optics

[Stephan Witt]

Am 13.08.2020 um 18:06 schrieb Daniel <xracoonx at gmx.de>:
> 
> On 2020-08-13 16:51, Richard Kimberly Heck wrote:
>> On 8/13/20 10:22 AM, Daniel wrote:
>>> The depth bar looks a bit out of shape (both in stable and master).
>>> The attached patch fixes this. See the attached screen captures - the
>>> "before" is taken in stable and the after in master that is the only
>>> reason why the length differs.
>> Any idea why this is happening? It would be worth a bisect. Although the
>> patch may work, it may simply be masking a problem that is coming from
>> elsewhere.
> 
> I can't do a bisect. It takes ages to compile a version because I am just using the installer script from Stephan which seems to compile everything from scratch. I couldn't make his proper cmake/Xcode script to work yet.

With some luck (i.e. not so big structure aka Makefile.am changes) you can do a bisect w/o repeated runs of the installer script.

The build tree is not removed after package creation on purpose. You may edit a source file and run make install as usual in the build tree. Therefore you can do the bisect that way. You may start the lyx app from command line with .../lyx-build/LyX-2.4.0dev.app if make install succeeds.

This probably fails for big range of commits because of file additions etc. If that’s the case you have to run the complete installer script to get the Makefiles right.

Stephan

PS: The following command line to build and run LyX lasts 3 secs for an empty change on my system.
 
(cd /Users/stephan/git/lyx-build/LyX-2.4.0dev.build/src && make install && open /Users/stephan/git/lyx-build/LyX-2.4.0dev.app)

> But it seems to me that part of the answer is that it wasn't taken into account that fillRect creates a filled rectangle without the border set by the pen. It seem pretty clear that this explains the part on the top. And it has come up elsewhere (https://www.lyx.org/trac/ticket/11925). I guess a warning about this could be added in the code to the fillRect function. The lower part I am not so sure.
> 
> My fix might look a little indirect because I had to make sure to not come into conflict with the re-painting of the rows. But I think it's a clear improvement over the previous state.
> -- 
> Daniel
> 
> -- 
> lyx-devel mailing list
> lyx-devel at lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel