Do We Care About Warnings Like...

Richard Kimberly Heck rikiheck at lyx.org
Sun Apr 19 15:39:31 UTC 2020


/cvs/lyx/lyx-devel/src/insets/InsetText.cpp:526: warning: implicit
conversion changes signedness:
'lyx::RandomAccessList<lyx::Paragraph>::size_type' (aka 'unsigned long')
to 'lyx::pit_type' (aka 'long')

The code here is:

rp.par_end = paragraphs().size();

and the fix would be

rp.par_end = static_cast<pit_type>(paragraphs().size());

or an 'old-style' cast, though that throws its own warning. (Do we care
about that?)

I don't propose to go through and fix all of these, but it is easy
enough to fix such things as I'm looking through the code for other
reasons.

Riki




More information about the lyx-devel mailing list