[LyX/master] Reimplement properly bidi icons
Richard Kimberly Heck
rikiheck at lyx.org
Wed Apr 15 13:35:35 UTC 2020
On 4/15/20 6:46 AM, Jean-Marc Lasgouttes wrote:
> Le 14/04/2020 à 22:27, Jean-Marc Lasgouttes a écrit :
>> commit 43eda5ad734e20e4759a225698f8977b9e38aa80
>> Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
>> Date: Tue Apr 14 22:41:00 2020 +0200
>>
>> Reimplement properly bidi icons
>> When the cursor in RTL text, icons for "depth-increment" or
>> "layout-toggle Enumerate" look wrong.
>> Instead of relying on the clumsy "bidi" lfun of 2898c335,
>> this new
>> version relies on a new Toobar tag BidiItem that inserts an action
>> which can have two icons, depending on the direction of the
>> paragraph
>> containing the caret (or of the direction of the UI when no file is
>> open).
>
> This new mechanism can probably be improved in several ways:
> * icons could be mirrored programmatically if the +rtl version is not
> provided (sufficient in most cases)
> * the same mechanism could be expanded to support 3-state save icon
> that we discussed earlier.
> * this could be extended to things more complicated than plain Items
> if there is a need.
>
> My real problem now is that I have removed the useless LFUN_BIDI
> function that is only needed for toolbar definition. Do I have to add
> a lfun2lfun stage for that? I suspect the risk of introducing a bug is
> larger than the benefit of updating something that nobody uses.
If it's really only needed for that, I wouldn't worry about it.
Riki
More information about the lyx-devel
mailing list