[LyX/master] Revert "Fix memory leak reported by Scott."
Richard Kimberly Heck
rikiheck at lyx.org
Sun Feb 23 21:11:27 UTC 2020
commit 72c581ebdb2b96d3409fc6118d28b1dbb1d268cd
Author: Richard Kimberly Heck <rikiheck at lyx.org>
Date: Sun Feb 23 16:29:58 2020 -0500
Revert "Fix memory leak reported by Scott."
It leads to a double delete error.
This reverts commit 11397a2e82ba19b69818f9891132ff7074bc1759.
---
src/Buffer.cpp | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index 56e19b8..eb65e81 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -545,10 +545,8 @@ Buffer::~Buffer()
if (it == cloned_buffers.end()) {
// We will leak in this case, but it is safe to continue.
LATTEST(false);
- } else {
- delete(*it);
+ } else
cloned_buffers.erase(it);
- }
delete d->clone_list_;
}
// FIXME Do we really need to do this right before we delete d?
More information about the lyx-cvs
mailing list