[LyX/master] Avoid potential leak of memory pointed to by QStandardItem catItem

Stephan Witt switt at lyx.org
Thu Feb 13 15:21:14 UTC 2020


commit aca95619b8a6d010ce4a52dac25d614e2ed467e5
Author: Stephan Witt <switt at lyx.org>
Date:   Thu Feb 13 15:24:12 2020 +0100

    Avoid potential leak of memory pointed to by QStandardItem catItem
---
 src/frontends/qt/GuiDocument.cpp |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/frontends/qt/GuiDocument.cpp b/src/frontends/qt/GuiDocument.cpp
index ac4b1f1..8778790 100644
--- a/src/frontends/qt/GuiDocument.cpp
+++ b/src/frontends/qt/GuiDocument.cpp
@@ -4467,12 +4467,13 @@ void GuiDocument::updateAvailableModules()
 	unavbrush.setColor(Qt::gray);
 	for (modInfoStruct const & m : modInfoList) {
 		QStandardItem * item = new QStandardItem();
-		QStandardItem * catItem = new QStandardItem();
+		QStandardItem * catItem;
 		QString const catname = m.category;
 		QList<QStandardItem *> fcats = modules_av_model_.findItems(catname, Qt::MatchExactly);
 		if (!fcats.empty())
 			catItem = fcats.first();
 		else {
+			catItem = new QStandardItem();
 			catItem->setText(catname);
 			catItem->setFont(catfont);
 			modules_av_model_.insertRow(i, catItem);


More information about the lyx-cvs mailing list