[LyX/master] Remove unneeded InsetFootlike::metrics/draw() methods

Jean-Marc Lasgouttes lasgouttes at lyx.org
Wed Mar 24 15:19:11 UTC 2021


commit b37929fdb33222bf55505343647838d0665a9e02
Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
Date:   Wed Mar 24 14:51:41 2021 +0100

    Remove unneeded InsetFootlike::metrics/draw() methods
    
    The font is already set to the buffer font when called from
    TextMetrics::redoParagraph and RowPainter::paintInset, because
    inheritFont() is false.
    
    Part of investigation of bug #12204.
---
 src/insets/InsetFootlike.cpp |   18 ------------------
 src/insets/InsetFootlike.h   |    4 ----
 2 files changed, 0 insertions(+), 22 deletions(-)

diff --git a/src/insets/InsetFootlike.cpp b/src/insets/InsetFootlike.cpp
index 739d897..36fc994 100644
--- a/src/insets/InsetFootlike.cpp
+++ b/src/insets/InsetFootlike.cpp
@@ -33,24 +33,6 @@ InsetFootlike::InsetFootlike(Buffer * buf)
 {}
 
 
-void InsetFootlike::metrics(MetricsInfo & mi, Dimension & dim) const
-{
-	FontInfo tmpfont = mi.base.font;
-	mi.base.font = mi.base.bv->buffer().params().getFont().fontInfo();
-	InsetCollapsible::metrics(mi, dim);
-	mi.base.font = tmpfont;
-}
-
-
-void InsetFootlike::draw(PainterInfo & pi, int x, int y) const
-{
-	FontInfo tmpfont = pi.base.font;
-	pi.base.font = pi.base.bv->buffer().params().getFont().fontInfo();
-	InsetCollapsible::draw(pi, x, y);
-	pi.base.font = tmpfont;
-}
-
-
 void InsetFootlike::write(ostream & os) const
 {
 	// The layoutName may contain a "InTitle" qualifier
diff --git a/src/insets/InsetFootlike.h b/src/insets/InsetFootlike.h
index 4173285..e0a3fd3 100644
--- a/src/insets/InsetFootlike.h
+++ b/src/insets/InsetFootlike.h
@@ -28,10 +28,6 @@ public:
 	bool hasSettings() const override { return false; }
 private:
 	///
-	void metrics(MetricsInfo &, Dimension &) const override;
-	///
-	void draw(PainterInfo & pi, int x, int y) const override;
-	///
 	void write(std::ostream & os) const override;
 	///
 	bool insetAllowed(InsetCode) const override;


More information about the lyx-cvs mailing list