[LyX/2.3.x] Fix bug 9961

Eugene Chornyi yu_jin at lyx.org
Mon Jan 4 09:32:42 UTC 2021


commit daa32db3bc34fb607bd139b8113a1fbe08d05f48
Author: Eugene Chornyi <yu_jin at lyx.org>
Date:   Sun Jan 3 20:11:49 2021 +0100

    Fix bug 9961
    
    remove the error message for not finding a pdf viewer (apparently empty string is returned by FindExecutable if the executable is a Windows Store app). If there is really no pdf viewer, let the Windows itself decide what to do (produce error or not and which one).
---
 development/Win32/pdfview/pdfview.nsi |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/development/Win32/pdfview/pdfview.nsi b/development/Win32/pdfview/pdfview.nsi
index 5e49a1e..01dd6e8 100644
--- a/development/Win32/pdfview/pdfview.nsi
+++ b/development/Win32/pdfview/pdfview.nsi
@@ -77,12 +77,6 @@ Section "View PDF file"
   System::Call "shell32::FindExecutable(t '$PLUGINSDIR\a.pdf', t '', t .r0)"
   StrCpy $ViewerFileName $0
   ${GetFileName} $ViewerFileName $Viewer
-
-  ${If} $Viewer == ""
-    MessageBox MB_OK|MB_ICONEXCLAMATION "No PDF viewer is installed. \
-        Please install a PDF viewer such as Adobe Reader."
-    Quit        
-  ${EndIf}
   
   ${if} $Viewer == "AcroRd32.exe"
   ${orif} $Viewer == "AcroRd64.exe"


More information about the lyx-cvs mailing list