[LyX features/cleanup/updateMacros4] Fix comments

Richard Kimberly Heck rikiheck at lyx.org
Fri Nov 13 01:01:02 UTC 2020


The branch, cleanup/updateMacros4, has been updated.

- Log -----------------------------------------------------------------

commit c4b7c8b52c20fc00002aa80598a8a8fd282ed91b
Author: Richard Kimberly Heck <rikiheck at lyx.org>
Date:   Thu Nov 12 20:13:19 2020 -0500

    Fix comments

diff --git a/src/insets/InsetInclude.cpp b/src/insets/InsetInclude.cpp
index 79ecaec..8088e61 100644
--- a/src/insets/InsetInclude.cpp
+++ b/src/insets/InsetInclude.cpp
@@ -1406,10 +1406,8 @@ void InsetInclude::updateMacros(DocIterator const & us, DocIterator const & scop
 	loadIfNeeded();
 	buffer().clearMacroLock();
 	if (child_buffer_) {
-		// We want an iterator that just points at the location of this inset,
+		// We want an iterator that points at the location of this inset,
 		// whereas the one we were passed has us on top.
-		// At least, that is how the updateMacros code was before RKH modified
-		// it. That is not to say they quite understand why it was like that.
 		DocIterator it = us;
 		it.pop_back();
 		buffer().registerChild(child_buffer_, it, scope);
diff --git a/src/mathed/InsetMathMacroTemplate.cpp b/src/mathed/InsetMathMacroTemplate.cpp
index a445b4d..bec791d 100644
--- a/src/mathed/InsetMathMacroTemplate.cpp
+++ b/src/mathed/InsetMathMacroTemplate.cpp
@@ -462,8 +462,8 @@ docstring InsetMathMacroTemplate::name() const
 
 void InsetMathMacroTemplate::updateMacros(DocIterator const & us, DocIterator const & scope)
 {
-	// This matches the previous code, but I am not sure why it
-	// should be like this.
+	// We want an interator here that points at this inset. The
+	// one we were passed has us on top.
 	DocIterator it = us;
 	it.pop_back();
 	MacroContext mc(&buffer(), it);

-----------------------------------------------------------------------

Summary of changes:
 src/insets/InsetInclude.cpp           |    4 +---
 src/mathed/InsetMathMacroTemplate.cpp |    4 ++--
 2 files changed, 3 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Repository for new features


More information about the lyx-cvs mailing list