[LyX/master] Fix Qt deprecation warns for setTextColor()

Scott Kostyshak skostysh at lyx.org
Thu Mar 19 14:11:41 UTC 2020


commit 8583410617c756e072ee997f918395d6f29b8246
Author: Scott Kostyshak <skostysh at lyx.org>
Date:   Thu Mar 19 10:16:19 2020 -0400

    Fix Qt deprecation warns for setTextColor()
    
    This commit fixes the following warning from Qt 5.14:
    
      error: ‘void QTreeWidgetItem::setTextColor(int, const QColor&)’ is deprecated: Use QTreeWidgetItem::setForeground() instead [-Werror=deprecated-declarations]
    
    setForeground was introduced in Qt 4.2 [1].
    
    We have a couple of commented out uses of a setTextColor() method in
    GuiDocument.cpp, but the QTextEdit::setTextColor() is not deprecated so no
    change is needed.
    
    [1] https://doc.qt.io/archives/qt-4.8/qtreewidgetitem.html#setForeground
---
 src/frontends/qt/PanelStack.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/frontends/qt/PanelStack.cpp b/src/frontends/qt/PanelStack.cpp
index c61c8e0..243542d 100644
--- a/src/frontends/qt/PanelStack.cpp
+++ b/src/frontends/qt/PanelStack.cpp
@@ -212,7 +212,7 @@ static void setTreeItemStatus(QTreeWidgetItem * tree_item, bool enabled)
 	// Change the color from black to gray or viceversa
 	QPalette::ColorGroup new_color =
 		enabled ? QPalette::Active : QPalette::Disabled;
-	tree_item->setTextColor(0, QApplication::palette().color(new_color,
+	tree_item->setForeground(0, QApplication::palette().color(new_color,
 	                                                         QPalette::Text));
 }
 


More information about the lyx-cvs mailing list